add task solution #4021
add task solution #4021
Conversation
osidanych
commented
Dec 17, 2024
osidanych
commented
- DEMO LINK
- TEST REPORT LINK
- Changing 'month-lengh' and 'start-day' modifier in the code element reflects in changing calendar layout
- Each day has no modifiers, only class (eg. calendar__day)
- All Typical Mistakes from BEM lesson theory are checked.
- Code follows all the Code Style Rules ❗️
There was a problem hiding this comment.
Thank you for your hard work on this project! 😊 There are a few critical issues that need to be addressed before we can approve your pull request:
-
SCSS File Naming: The SCSS file should be named
main.scssas per the task requirements. Please renameindex.scsstomain.scss. -
BEM Modifiers: Ensure that the BEM modifiers for
start-dayandmonth-lengthare implemented correctly and that changing these modifiers reflects in the calendar layout as expected. -
Checklist Verification: Verify that each day has no modifiers, only a class (e.g.,
calendar__day), to ensure compliance with the checklist. -
Code Duplication: There's a redundant block of code in your SCSS file that duplicates the logic found in lines 69-74. Removing this will help avoid unnecessary duplication and potential confusion.
Once these issues are resolved, your code will be in great shape! Keep up the great work, and feel free to reach out if you have any questions or need further assistance. 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/styles/index.scss
Outdated
| @each $day, $i in $days { | ||
| .calendar--start-day-#{$day} .calendar__day:first-child { | ||
| margin-left: calc(#{$i} * $cell-size + #{$i * $gap}); | ||
| } |
There was a problem hiding this comment.
This block of code is redundant because it duplicates the logic found in lines 69-74. You should remove this block to avoid unnecessary duplication and potential confusion.
There was a problem hiding this comment.
Great job on addressing the previous review comments! 🎉 Your SCSS file is now correctly named main.scss, and the BEM modifiers for start-day and month-length are implemented effectively using @each and @for. The code is clean and concise, with no redundant blocks. However, there's a minor issue with the HTML file still linking to styles/index.scss instead of styles/main.scss. Please update this link to ensure the correct SCSS file is used.
This decision to approve is made to help you move forward with your learning journey. Remember to review the comments to improve your code further. Addressing these issues will enhance the functionality and appearance of your calendar. Keep up the great work, and continue learning from these experiences! 🚀
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
| <div class="calendar calendar--start-day-sun calendar--month-length-31"> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| <div class="calendar__day"></div> | ||
| </div> |
There was a problem hiding this comment.
Ensure that the BEM modifiers for start-day and month-length are correctly implemented and that changing these modifiers reflects in the calendar layout as expected. This is crucial for maintaining the intended functionality and appearance of the calendar.
| @for $i from 28 through 31 { | ||
| .calendar--month-length-#{$i} .calendar__day:nth-child(n + #{$i + 1}) { | ||
| display: none; | ||
| } | ||
| } |
There was a problem hiding this comment.
Ensure that the BEM modifiers for month-length are correctly implemented and that changing these modifiers reflects in the calendar layout as expected. This is crucial for maintaining the intended functionality and appearance of the calendar.
| @each $day, $i in $days { | ||
| .calendar--start-day-#{$day} .calendar__day:first-child { | ||
| margin-left: calc(#{$i} * $cell-size + #{$i * $gap}); | ||
| } | ||
| } |
There was a problem hiding this comment.
Ensure that the BEM modifiers for start-day are correctly implemented and that changing these modifiers reflects in the calendar layout as expected. This is crucial for maintaining the intended functionality and appearance of the calendar.
